search

dougbinks / enkiTS

A permissively licensed C and C++ Task Scheduler for creating parallel programs. Requires C++11 support.
zlib License
1.74k stars 145 forks source link

Warning regarding padding with VS 2019 16.11.7 #67

Closed BobbyAnguelov closed 2 years ago

BobbyAnguelov commented 2 years ago

Just integrated v1.10 and have this: warning C4324: 'enki::ThreadDataStore': structure was padded due to alignment specifier.

I'm gonna suppress the warning on my side as I have warnings as errors on, but maybe it would be good to pad it manually?

dougbinks commented 2 years ago

Looks like I forgot to modify the prevent_false_Share size, I've altered that and added a better static_assert. Will double check tomorrow and push a fix.

Thanks for the report!

dougbinks commented 2 years ago

I've pushed the changes to the dev branch, will merge to master after further testing.

dougbinks commented 2 years ago

This is now merged into master so I'll close this issue, but if you still find the warning do re-open it and I'll figure out what I missed.