search

dougbw / coredns_omada

CoreDNS plugin for TP-Link Omada SDN
Apache License 2.0
90 stars 9 forks source link

[Feature Request] Allow . in DNS names #27

Closed friggeri closed 9 months ago

friggeri commented 9 months ago

I have a few security cameras I'd like to group together in a subdomain (as in [location].cam.[domain]), currently the period gets stripped here, would be great to have the option to not strip a .

dougbw commented 9 months ago

Hi. Adding a . in a DNS host generally indicates a sub domain. Although some DNS systems do support this arbitrarily adding dots to a given hostname it can have mixed results in some scenarios so I would be hesitant about implementing it for this project as it could lead to weird issues that would be difficult to track down.

In your case I would recommend going with [location]-cam.[domain]

See https://www.ietf.org/rfc/rfc1034.txt:

A domain is identified by a domain name, and consists of that part of
the domain name space that is at or below the domain name which
specifies the domain.  A domain is a subdomain of another domain if it
is contained within that domain.  This relationship can be tested by
seeing if the subdomain's name ends with the containing domain's name.
For example, A.B.C.D is a subdomain of B.C.D, C.D, D, and " ".
friggeri commented 9 months ago

Yes that's actually what I want to do: I'd like to be able to configure certain clients to all have a fqdn that is a subdomain of cam.[domain]

An alternative way of doing this would be to put them on a different lan where the host domain is cam.[domain], but that comes with a bit of overhead, I was hoping to avoid doing that by being able to encoding that in the name field in Omada.

dougbw commented 9 months ago

I will take a look at this the next time I am working on an update, but my gut feeling is that its going to add too much complexity for what it is worth, so again would advise to go with the flat domain of [location]-cam.[domain]

friggeri commented 9 months ago

I ended up just creating multiple vlans with different domains, it was a bit of hassle but I actually like where things ended up. Thanks for getting me to do things "properly" ;)

dougbw commented 9 months ago

Glad you got it sorted!