Conversion Error of AccountEntryType

dougdellolio / coinbasepro-csharp

The unofficial .NET/C# client library for the Coinbase Pro/GDAX API

MIT License

193 stars 90 forks source link

Conversion Error of AccountEntryType #180

Closed ryanfalzon closed 5 years ago

ryanfalzon commented 5 years ago

Getting the error below when invoking the method 'AccountsService.GetAccountHistoryAsync'

Newtonsoft.Json.JsonSerializationException: 'Error converting value "conversion" to type 'CoinbasePro.Services.Accounts.Types.AccountEntryType'. Path '[0].type', line 1, position 145.'

dougdellolio commented 5 years ago

hi @ryanfalzon thanks for catching this. I have added a fix here: https://github.com/dougdellolio/coinbasepro-csharp/pull/181 this also contains a change that will prevent this from happening ever again should they add another type. New types will be set to Unknown

ryanfalzon commented 5 years ago

Will this update be releases in nuget?