search

dougdellolio / coinbasepro-csharp

The unofficial .NET/C# client library for the Coinbase Pro/GDAX API
MIT License
192 stars 90 forks source link

[Feature] Added OXT to currency enum #215

Closed confessore closed 4 years ago

confessore commented 4 years ago

sure thing. also had some questions about why the GetAllOrdersAsync() is a IList<IList> when there is only ever one list that gets populated from what I can see. https://github.com/dougdellolio/coinbasepro-csharp/blob/master/CoinbasePro/Services/Orders/IOrdersService.cs

dougdellolio commented 4 years ago

thanks. and this is because it is a paginated response from coinbase (you can receive multiple pages with multiple orders). if you have enough orders to fill one page on the first request then it will be only one page of orders in the response. There is some more explanation here in the comments of how the parameters work for limit and numberOfPages (https://github.com/dougdellolio/coinbasepro-csharp#getting-account-history-paged-response). let me know if that still doesn't make sense.

confessore commented 4 years ago

thanks. this makes sense since I only have 91 total orders made on the account. I'll check it out again once I have over 100