search

dougdellolio / coinbasepro-csharp

The unofficial .NET/C# client library for the Coinbase Pro/GDAX API
MIT License
192 stars 90 forks source link

[Feature] Change Product Pairs and Currencies from enums to strings #280

Closed dougdellolio closed 3 years ago

dougdellolio commented 3 years ago

As Coinbase Pro has been adding new trading pairs weekly, it no longer makes sense to keep an updated list of enums for product pairs as this is manual and requires constant releases. This change is breaking, however, it will allow the user to take advantage of new trading opportunities immediately by allowing any trading pair (ex. "BTC-USD") to be used.

An example request

Before:

await coinbaseProClient.ProductsService.GetProductOrderBookAsync(ProductType.BtcUsd)

After:

await coinbaseProClient.ProductsService.GetProductOrderBookAsync("BTC-USD")