Open bchoinski-cb opened 3 years ago
I do appreciate the offer but I'm not very literate with python so I don't think I could use it as an alternate (other than just running it as-is) as I wouldn't be able to easily maintain/update it if I wanted to make further changes and I would want to post it here on Github for others to use/modify. I do agree that the randomizer.pl script has a lot ;) of issues as its mostly just thrown together to see if the idea was feasible, and feature creep occurred, etc.
However, having said that, and if you don't want to post your version on Github I would be interested on the names of the module/libraries you used in python to perform any XML parsing/manipulation. I would like to see how Python handles the XML query/get/set operations vs Perl. Perl has been around for a long time and as a result a lot of its freely available modules on CPAN are old/out of date and sometimes its not easy to choose modules/libraries that are maintained and easy to use and up to date with the latest standards (hence the "Modern Perl" vs "old Perl ways" debacle). Python has been around for awhile but it seems they are less of a victim of time/age (and open source library/module bloat) than Perl and are more up to date with the latest standards even though I see them going through the same growing pains that Perl went through long ago, meaning there are areas where Python is still a little rough (IMHO). Specifically the "Python 2 "vs "Python 3" compatibility debacle (which is basically over and done with now, as I see it), and some other things Python still does that feel like they're still figuring out how they want to do things in a "Pythonic" way (like string formatting). But I ramble on, and I really don't keep up with Python enough to be on top of things, so maybe I'm already out of date on the subject ;)
Well, just thought you might like to take a peak. It varies a bit from your core in some generation, specifically size and mass/weight (I have it more tied), having added a new scaling method.
One bug I think I found, and corrected in my data, is the move speed variance. I saw a low value of 0.05, where I think you wanted 0.5. I have seen vultures and dogs on attack runs that looked like they were running through thick jello and were real easy to target and kill.
Burton Choinski Member Technical Staff bchoinski@vmware.com mailto:bchoinski@vmware.com%0b3401 Hillview Avenue, Palo Alto, CA 94304 Office: 508.843.7183 Mobile: 508.843.7183
[VMware]http://www.carbonblack.com/
From: doughphunghus notifications@github.com Reply-To: doughphunghus/7D2D-EntityRandomizer reply@reply.github.com Date: Saturday, January 16, 2021 at 1:05 PM To: doughphunghus/7D2D-EntityRandomizer 7D2D-EntityRandomizer@noreply.github.com Cc: Burton Choinski bchoinski@vmware.com, Author author@noreply.github.com Subject: Re: [doughphunghus/7D2D-EntityRandomizer] New code (#6)
I do appreciate the offer but I'm not very literate with python so I don't think I could use it as an alternate (other than just running it as-is) as I wouldn't be able to easily maintain/update it if I wanted to make further changes and I would want to post it here on Github for others to use/modify. I do agree that the randomizer.pl script has a lot ;) of issues as its mostly just thrown together to see if the idea was feasible, and feature creep occurred, etc.
However, having said that, and if you don't want to post your version on Github I would be interested on the names of the module/libraries you used in python to perform any XML parsing/manipulation. I would like to see how Python handles the XML query/get/set operations vs Perl. Perl has been around for a long time and as a result a lot of its freely available modules on CPAN are old/out of date and sometimes its not easy to choose modules/libraries that are maintained and easy to use and up to date with the latest standards (hence the "Modern Perl" vs "old Perl ways" debacle). Python has been around for awhile but it seems they are less of a victim of time/age (and open source library/module bloat) than Perl and are more up to date with the latest standards even though I see them going through the same growing pains that Perl went through long ago, meaning there are areas where Python is still a little rough (IMHO). Specifically the "Python 2 "vs "Python 3" compatibility debacle (which is basically over and done with now, as I see it), and some other things Python still does that feel like they're still figuring out how they want to do things in a "Pythonic" way (like string formatting). But I ramble on, and I really don't keep up with Python enough to be on top of things, so maybe I'm already out of date on the subject ;)
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdoughphunghus%2F7D2D-EntityRandomizer%2Fissues%2F6%23issuecomment-761607495&data=04%7C01%7Cbchoinski%40vmware.com%7C3943a00824214733bf9e08d8ba493e24%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637464171074693311%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=gminnfSiX7Aa%2F8loSGeBT%2FfMZqhVt%2FbhhZEkcjh48io%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FANL3KDBTH6D5WYIND2YF2MTS2HIMZANCNFSM4WBN32VQ&data=04%7C01%7Cbchoinski%40vmware.com%7C3943a00824214733bf9e08d8ba493e24%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637464171074693311%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=LTky03Wxj3%2BVg6Tho2WqO%2FO0x6Zr3LbdF3QDdSbKpnI%3D&reserved=0.
Oops, only think that nees to change is modlet_gen_start and modlet_gen_finish. The tag there is “Trubs” so as to keep it distinct from yours, but that should have been dragged from the config. Need to alter that locally.
Burton Choinski Member Technical Staff bchoinski@vmware.com mailto:bchoinski@vmware.com%0b3401 Hillview Avenue, Palo Alto, CA 94304 Office: 508.843.7183 Mobile: 508.843.7183
[VMware]http://www.carbonblack.com/
From: doughphunghus notifications@github.com Reply-To: doughphunghus/7D2D-EntityRandomizer reply@reply.github.com Date: Saturday, January 16, 2021 at 1:05 PM To: doughphunghus/7D2D-EntityRandomizer 7D2D-EntityRandomizer@noreply.github.com Cc: Burton Choinski bchoinski@vmware.com, Author author@noreply.github.com Subject: Re: [doughphunghus/7D2D-EntityRandomizer] New code (#6)
I do appreciate the offer but I'm not very literate with python so I don't think I could use it as an alternate (other than just running it as-is) as I wouldn't be able to easily maintain/update it if I wanted to make further changes and I would want to post it here on Github for others to use/modify. I do agree that the randomizer.pl script has a lot ;) of issues as its mostly just thrown together to see if the idea was feasible, and feature creep occurred, etc.
However, having said that, and if you don't want to post your version on Github I would be interested on the names of the module/libraries you used in python to perform any XML parsing/manipulation. I would like to see how Python handles the XML query/get/set operations vs Perl. Perl has been around for a long time and as a result a lot of its freely available modules on CPAN are old/out of date and sometimes its not easy to choose modules/libraries that are maintained and easy to use and up to date with the latest standards (hence the "Modern Perl" vs "old Perl ways" debacle). Python has been around for awhile but it seems they are less of a victim of time/age (and open source library/module bloat) than Perl and are more up to date with the latest standards even though I see them going through the same growing pains that Perl went through long ago, meaning there are areas where Python is still a little rough (IMHO). Specifically the "Python 2 "vs "Python 3" compatibility debacle (which is basically over and done with now, as I see it), and some other things Python still does that feel like they're still figuring out how they want to do things in a "Pythonic" way (like string formatting). But I ramble on, and I really don't keep up with Python enough to be on top of things, so maybe I'm already out of date on the subject ;)
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdoughphunghus%2F7D2D-EntityRandomizer%2Fissues%2F6%23issuecomment-761607495&data=04%7C01%7Cbchoinski%40vmware.com%7C3943a00824214733bf9e08d8ba493e24%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637464171074693311%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=gminnfSiX7Aa%2F8loSGeBT%2FfMZqhVt%2FbhhZEkcjh48io%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FANL3KDBTH6D5WYIND2YF2MTS2HIMZANCNFSM4WBN32VQ&data=04%7C01%7Cbchoinski%40vmware.com%7C3943a00824214733bf9e08d8ba493e24%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637464171074693311%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=LTky03Wxj3%2BVg6Tho2WqO%2FO0x6Zr3LbdF3QDdSbKpnI%3D&reserved=0.
"One bug I think I found, and corrected in my data, is the move speed variance. I saw a low value of 0.05, where I think you wanted 0.5." Ha, yeah, that was probably an oversight. I think at one point I was working on crawlers and wanting them to have a wide speed range, which is probably where this came from.
I plan on doing some more updates/cleanup when a20 comes out, as I was trying to get it to add archetypes to the zeds as an option (clothes, hats, hair color, etc) and then I found out TFP is completely redoing it with their own custom archetype system, so I stopped updating for now.
Anyway: When a20 comes out and I come back to this project, I might hit you up on that source code offer :). If its a lot cleaner than mine (and it likely is, I threw this together without mush care for maintenance) and if the python is mostly string manipulations, etc nothing super fancy I might be able to get my head around it.
Not an issue as much as an alternate. We liked your module, had a few issues with it. I made a Python version of it that I can run locally, SHOULD work fine with your configs but does a few things differently. If you can email me (at bchoinski@verizon.net), I can send you my python source variant (and config file I used), if you want to compare or use it as an alternate.