search

douglascamata / setup-docker-macos-action

A Github Action to setup Docker on macOS runners.
MIT License
29 stars 9 forks source link

Install docker buildx #29

Open owenthereal opened 7 months ago

owenthereal commented 7 months ago

It would be nice docker buildx is included as well. Thanks!

douglascamata commented 6 months ago

@owenthereal did you notice that docker buildx is missing? Do you have logs of a build that tried to use it and it wasn't there? I am asking because this actions installs Docker with Homebrew (brew install docker) and it installs https://github.com/docker/cli, which includes docker buildx.

thallgren commented 1 month ago

I just noticed this too. Logs from the build can be found here. The steps of interest is "Run douglascamata/setup-docker-macos-action@v1-alpha" and "Build client image".

thallgren commented 1 month ago

I added this step to my workflow, and it seems to do the trick:

        run: |
          mkdir -p "${HOME}/.docker/cli-plugins"
          curl -fL https://github.com/docker/buildx/releases/download/v0.16.2/buildx-v0.16.2.darwin-amd64 -o "${HOME}/.docker/cli-plugins/docker-buildx"
          chmod +x "${HOME}/.docker/cli-plugins/docker-buildx"
douglascamata commented 1 month ago

Looks like there is a separate formula for docker buildx now (see https://formulae.brew.sh/formula/docker-buildx). I'll add it to the action.

Thanks for the extra information, @thallgren