douglascamata / setup-docker-macos-action

A Github Action to setup Docker on macOS runners.
MIT License
29 stars 9 forks source link

Fix errors when using cache #8

Closed humdrum closed 1 year ago

humdrum commented 1 year ago

The lima package depends on the qemu package.

% brew info lima
==> lima: stable 0.17.0 (bottled), HEAD
Linux virtual machines
https://github.com/lima-vm/lima
Not installed
From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/lima.rb
License: Apache-2.0
==> Dependencies
Build: go ✘
Required: qemu ✘

So I added the qemu installation by brew before restoring cached packages.

I tried to cache the quemu and packages that depend on it. But the qumu could not be recovered.

Although Not all brew cellars are cached, it would be worthwhile for docker to be cached.

스크린샷 2023-08-10 오후 9 22 46
douglascamata commented 1 year ago

I want to avoid as much as possible reinstalling QEMU, as it takes too long, but it has been difficult to achieve. So I guess that's necessary.

@humdrum can you move it to a separate step, please, for organization purposes?

douglascamata commented 1 year ago

Probably when I feel confident with the rewrite to JS of the action I can solve this issue, as it's much easier to parse and cache all the dependencies in JS with the Github Action libraries.

douglascamata commented 1 year ago

Closes #7

douglascamata commented 1 year ago

I created #9 to track future improvements on caching.