Creating duplicate files for already converted files

[gribis]

When I am running the batch process multiple times for the same parent records, it appears that the duplicate prevention method (filterAlreadyConvertedAttachmentIds) is not catching already converted files. So I did some digging, trying to replicate what the dup-prevention method does: Retrieve ContentVersion records for already converted attachments. SELECT original_record_id__c FROM ContentVersion WHERE original_record_id__c='{attachmentId}’ Oddly enough, this query does not return any records for known converted attachment Ids. However, if I include the ContentVersion.Id or the ContentDocumentId in the same query, the record is returned. SELECT original_record_id__c FROM ContentVersion WHERE original_record_id__c='{attachmentId}’ AND Id='{ContentVersionId}' The settings are as follows:

• Share the files with all users who have access to the attachment's parent record
• All Users (recommended if communities is enabled)
• Users inherit view or edit access to the file based on their view or edit access to the attachment's parent record (recommended)
• Keep them; I have great plans for the attachments...

While I have attempted to remove files upon completion, that has not worked thus far either, which may be related to the issue. I am running the process as an admin with audit data update privileges.

[douglascayers]

Hi @gribis,

Thanks for the detailed information, this is quite helpful! Do you notice this problem if you run the conversion scoped to a single parent record? Do you happen to notice the issue related to specific parent records or parent object types? Anything you notice about the owners of the attachments? Have a Role, don't have a Role? Salesforce license type of the owners?

I'm wondering if there's an edge case to uncover...

Thanks

[douglascayers]

Confirmed that we're running into a special access rule with ContentVersion records. Despite being an administrator with Modify All Data permission, if the current user does not own the record then they do not find any results when simply querying SELECT id FROM ContentVersion WHERE original_record_id__c = :attachment.id ]

Researching what other options we have; I'd hate to have to create a custom object for tracking whether attachment has been converted or not. Just feels icky to me. We'll see...

[douglascayers]

Good news, I think I've solved it by instead querying ContentDocumentLink object! I'll do some further testing soon and hopefully have new release available this week.

Thanks

[gribis]

I saw your finding and will attempt to integrate with my version of the code. Nice work on tracking this down. Best, Stefan

On Apr 10, 2017, at 11:32 PM, Doug Ayers notifications@github.com wrote:

Closed #19 via 10d9ea0.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.