merge efforts into istanbul?

douglasduteil / isparta

:skull: A code coverage tool for ES6 (babel/6to5)

Do What The F*ck You Want To Public License

642 stars 47 forks source link

merge efforts into istanbul? #31

Open gotwarlost opened 9 years ago

gotwarlost commented 9 years ago

Hi, istanbul author here.

Would it make sense to add options to istanbul to make what you are doing possible directly in it?

Example:

Allow a pre-loader hook that istanbul respects for babel transforms to es6 files
Add source map support

My vested interest in this is that there are many other applications other than ES6 where source maps for instance is useful (e.g. minification/ bundling use cases for es5)

etc.

douglasduteil commented 9 years ago

Hi there

It would be awesome ! I have no time to do it right now but it will definitely be better for all the community :D

I red a lot of code from you guys but I still don't get how Istanbul is doing all the magic. This repo is just some kind of fork of Ibrik which the same hacks long before me. Did you get in contact with them too ?

gotwarlost commented 9 years ago

No - I didn't. It's just that a bunch of people have been asking for es6 support even at where I work so I thought I might do something about it. Let me know when we can collaborate on this. I might try to add source map support to istanbul in the meantime.

sethpollack commented 9 years ago

:+1:

DrewML commented 9 years ago

+1. Strong interest in this one!

roman01la commented 9 years ago

deepsweet commented 9 years ago

mysterycommand commented 9 years ago

:+1:

himmelarthur commented 9 years ago

:+1:

freeqaz commented 9 years ago

:+1:

egor-smirnov commented 9 years ago

gotwarlost commented 9 years ago

https://github.com/gotwarlost/istanbul/issues/212#issuecomment-117299669

is an attempt to get source-map support directly into istanbul. Anyone who can help me test this?

douglasduteil commented 9 years ago

Alright @gotwarlost i finally got something in progress! Stay tuned :)

douglasduteil commented 9 years ago

And @MalikAbed is helping me on this :+1:

douglasduteil commented 9 years ago

Hi @gotwarlost

We made a first hack here with this little modification.

What you think ?

douglasduteil commented 9 years ago

The goal is making Istanbul support extra transpiled sourcemap. All future transpilers just have need a little module called istanbul-<name> and expose a function than transform code to ES5 and return a result object like

{
  code: String,
  map: String
}

See istanbul-babel example

gotwarlost commented 9 years ago

I'm not in favor of modifying istanbul's instrumenter for dealing with source maps. This is because a source-map can map the code being instrumented into locations in multiple files which your modification does not handle correctly. For generality, I believe we should leave the instrumenter the way it is and transform the resultant coverage object at reporting time (which is what the source-map branch of istanbul does)

douglasduteil commented 9 years ago

Alright.

So the process is :