douglasjunior / react-native-keyboard-manager

⚛ Library to prevent issues of keyboard sliding up and cover inputs on React-Native iOS projects.
https://www.npmjs.com/package/react-native-keyboard-manager
MIT License
971 stars 59 forks source link

README install instructions are incorrect #48

Closed WoodyWoodsta closed 5 years ago

WoodyWoodsta commented 5 years ago

I ran react native link react-native-keyboard-manager, expecting it to link in the required libraries (not via a pod), however, it added a dependency in my Podfile and left the xcode project file untouched.

If this is intended, can you please include instructions on how to link this project into the iOS xcode project manually?

douglasjunior commented 5 years ago

This is strange, because the react-native link dont have relations with cocoapods.

What is your react-native-cli version? Maybe something changed?

douglasjunior commented 5 years ago

I know that the React Native team had intentions of integrating Cocoapods by default, but I dont know if this has already happened.

WoodyWoodsta commented 5 years ago
$ react-native -v
react-native-cli: 2.0.1
react-native: 0.58.6

Those were my thoughts as well. For now, I've manually linked it into the xcode project, but for less-knowledgable consumers, it would be the end of the road :)

douglasjunior commented 5 years ago

We need to find out if that really has changed.

iwikal commented 5 years ago

My experience: I installed it with npm i react-native-keyboard-manager and ran react-native run-ios --device, but nothing changed. After I ran pod install I could see changes in xcode project and in Podfile.lock, so I compiled again and then it worked. I think that's standard for a react-native dependency on ios these days.