search

douglasjunior / react-native-keyboard-manager

⚛ Library to prevent issues of keyboard sliding up and cover inputs on React-Native iOS projects.
https://www.npmjs.com/package/react-native-keyboard-manager
MIT License
971 stars 59 forks source link

fix: use <React/*.h> header import styles for compatibility with Expo SDK 44 #86

Closed fobos531 closed 2 years ago

fobos531 commented 2 years ago

First of all, thanks for the awesome library! It has greatly improved the keyboard handling UX in my apps.

However, after the upgrade to Expo SDK 44 in my app, I noticed that this Pod fails to compile. The root of the issue is that starting with SDK 44, Expo enforces the usage of #import <React/*.h> React header import style instead of #import "*.h"

See this discussion for more info: https://github.com/expo/expo/issues/15622#issuecomment-997141629

This PR alters the imports in this library so the Pod successfully compiles.

douglasjunior commented 2 years ago

Hi @fobos531 thank you for the PR!

I will just try with a bare React Native and come back with feedback.

martinezleoml commented 2 years ago

Applying these changes locally with Expo SDK 44 also solved the issue on my side (bare React Native app with Expo SDK). Thanks for the fix. :)

ddikodroid commented 2 years ago

@douglasjunior is it possible to merge this PR?

douglasjunior commented 2 years ago

Done!

douglasjunior commented 2 years ago

Release https://github.com/douglasjunior/react-native-keyboard-manager/releases/tag/6.5.4-4