search

douglasrizzo / catsim

Computerized Adaptive Testing Simulator
GNU Lesser General Public License v3.0
124 stars 35 forks source link

Some selectors are selecting the min informative items #11

Closed machow closed 6 years ago

machow commented 6 years ago

I may have missed something, but it looks like some selectors are selecting minimally informative items.

https://github.com/douglasrizzo/catsim/blob/master/catsim/selection.py#L840-L842

Since np.argsort() sorts in ascending order, the Randomesque selector is choosing from the least X informative items.

Should be a quick fix! Either by multiplying info by -1 or using reversed. Happy to open a PR!

douglasrizzo commented 6 years ago

Hey, thanks for the contribution! If you want to open two PRs or one PR for both issues to take credit for the fix, go ahead. I can also take a and fix it later.