douglasrizzo / catsim

Computerized Adaptive Testing Simulator
GNU Lesser General Public License v3.0
124 stars 35 forks source link

error in HillClimbingEstimator when items passed to estimate method #12

Closed machow closed 5 years ago

machow commented 5 years ago

It looks like when items is passed, it is supposed to use those. However, it tries to use self.simulator.items (which might not exist, and shouldn't be used in this case). Here's a link to a diff of how I was able to fix.

https://github.com/datacamp/catsim/commit/d18a8d7db746bdb3fe692267fc216cb24a2af83c