search

dougludlow / ng2-bs3-modal

Angular Bootstrap 3 Modal Component
http://dougludlow.github.io/ng2-bs3-modal/
ISC License
261 stars 133 forks source link

Doesn't work with RXJS 6 (Angular 6) #238

Closed Frennetix closed 6 years ago

Frennetix commented 6 years ago

If you start a new project with angular and angular/cli 6.x.x you'll get the following error:

ERROR in ./node_modules/ng2-bs3-modal/bundles/ng2-bs3-modal.umd.js
Module not found: Error: Can't resolve 'rxjs/Observable' in '...\node_modules\ng2-bs3-modal\bundles'
ERROR in ./node_modules/ng2-bs3-modal/bundles/ng2-bs3-modal.umd.js
Module not found: Error: Can't resolve 'rxjs/Subject' in '...\node_modules\ng2-bs3-modal\bundles'
ERROR in ./node_modules/ng2-bs3-modal/bundles/ng2-bs3-modal.umd.js
Module not found: Error: Can't resolve 'rxjs/add/observable/fromEvent' in '...\node_modules\ng2-bs3-modal\bundles'
ERROR in ./node_modules/ng2-bs3-modal/bundles/ng2-bs3-modal.umd.js
Module not found: Error: Can't resolve 'rxjs/add/observable/merge' in '...\node_modules\ng2-bs3-modal\bundles'
ERROR in ./node_modules/ng2-bs3-modal/bundles/ng2-bs3-modal.umd.js
Module not found: Error: Can't resolve 'rxjs/add/observable/of' in '...\node_modules\ng2-bs3-modal\bundles'
ERROR in ./node_modules/ng2-bs3-modal/bundles/ng2-bs3-modal.umd.js
Module not found: Error: Can't resolve 'rxjs/add/observable/zip' in '...\node_modules\ng2-bs3-modal\bundles'
ERROR in ./node_modules/ng2-bs3-modal/bundles/ng2-bs3-modal.umd.js
Module not found: Error: Can't resolve 'rxjs/add/operator/do' in '...\node_modules\ng2-bs3-modal\bundles'
ERROR in ./node_modules/ng2-bs3-modal/bundles/ng2-bs3-modal.umd.js
Module not found: Error: Can't resolve 'rxjs/add/operator/filter' in '...\node_modules\ng2-bs3-modal\bundles'
ERROR in ./node_modules/ng2-bs3-modal/bundles/ng2-bs3-modal.umd.js
Module not found: Error: Can't resolve 'rxjs/add/operator/map' in '...\node_modules\ng2-bs3-modal\bundles'
ERROR in ./node_modules/ng2-bs3-modal/bundles/ng2-bs3-modal.umd.js
Module not found: Error: Can't resolve 'rxjs/add/operator/share' in '...\node_modules\ng2-bs3-modal\bundles'
ERROR in ./node_modules/ng2-bs3-modal/bundles/ng2-bs3-modal.umd.js
Module not found: Error: Can't resolve 'rxjs/add/operator/take' in '...\node_modules\ng2-bs3-modal\bundles'
ERROR in ./node_modules/ng2-bs3-modal/bundles/ng2-bs3-modal.umd.js
Module not found: Error: Can't resolve 'rxjs/add/operator/toPromise' in '...\node_modules\ng2-bs3-modal\bundles'
i ｢wdm｣: Failed to compile.
ERROR in node_modules/ng2-bs3-modal/modal/modal-service.d.ts(1,10): error TS2305: Module '".../node_modules/rxjs/Observable"' has no exported member 'Observable'.
node_modules/rxjs/Observable.d.ts(1,15): error TS2307: Cannot find module 'rxjs-compat/Observable'.

ng2-bs3-modal should upgrade to rxjs6.

Frennetix commented 6 years ago

help can be found here: https://github.com/ReactiveX/rxjs-tslint

dougludlow commented 6 years ago

Should be fixed in v0.15.0.