search

dougludlow / ng2-bs3-modal

Angular Bootstrap 3 Modal Component
http://dougludlow.github.io/ng2-bs3-modal/
ISC License
261 stars 133 forks source link

dist pakage to be created #239

Open balkrishna0007 opened 6 years ago

balkrishna0007 commented 6 years ago

Please create clean dist package to include in projects using gulp also provide info how to refer distribute package through gulp or any other packaging library.

dougludlow commented 6 years ago

@balkrishna0007 - I'm sorry I don't understand. Gulp is a task runner, not a packaging library.

balkrishna0007 commented 6 years ago

i am unable to get ng2-bs3-modal latest version in my vs code can you mention steps which files required to be kept in wwwroot folder also what configration has to be done at systemjs.config, package.json and gulp command to include this pakage

also what about ngx.bs3.modal???

wartab commented 6 years ago

Everything is described in the readme. If you have trouble making it work following the described procedure, I recommend posting the error messages you are getting.

You seem to have a problem understanding your toolset: Gulp has nothing to do with package inclusion.

Ottunger commented 6 years ago

I've had troubles having it run with Jasmine because of this "issue": Jasmine loads files from node_modules without any transpiling, and this package contains ES6 modules, which are currently not supported by node (still is an experimental feature).

I had to create a dist folder using babel as a postinstall script to load tests from non-ES6 modules. I first wanted to use babel-node, but it cannot be (easily?) configured to transpile files loaded from node_modules.