WIP: Update ng and rxjs dependencies and imports to version 6. FIXES #240.

dougludlow / ng2-bs3-modal

Angular Bootstrap 3 Modal Component

http://dougludlow.github.io/ng2-bs3-modal/

ISC License

261 stars 133 forks source link

WIP: Update ng and rxjs dependencies and imports to version 6. FIXES #240. #241

Closed ishehata closed 6 years ago

ishehata commented 6 years ago

Still need to fix import and usage of JQueryStyleEventEmitter (need help)
What should be the new version number ?

dougludlow commented 6 years ago

Thanks @emostafa! There appear to be some build errors. I'll see if I can take a look at them tonight. As far as version goes, incrementing the minor for now to v0.14.0 makes sense to me.

ishehata commented 6 years ago

Hi @dougludlow, Hope it's a quick fix, the errors are related to ng test --single-run, I've tried to fix it but didn't get a successful change.

gokul1794 commented 6 years ago

Hey guys any updates? Would be great if this could work with Angular 6

ranjik2909 commented 6 years ago

Can anyone please tell me if ng2-bs3-modal works with Angular 5.2? If it does, what are the changes that need to be made for making it work with 5.2?