Base plugin-sass on css-plugin-base?

dougludlow / plugin-sass

SystemJS SASS loader plugin

MIT License

52 stars 27 forks source link

Base plugin-sass on css-plugin-base? #72

Closed ineentho closed 7 years ago

ineentho commented 8 years ago

Have you thought about basing this plugin on plugin-css as the less plugin does? I think we should learn some things from them.

One problem I'm having with this plugin is that incremental builds get really slow because it seems like the cache doesn't work, which I believe is solved correctly by the less plugin.

If I were to prepare a pull request that implements it, would you consider to merge it?

screendriver commented 8 years ago

Thank you for the suggestion. Any pull request is welcome 😎 👍

dougludlow commented 7 years ago

@ineentho feel free to submit a or any time, if your still interested. I'll close this issue for now.

From what I understand, the main reason it's pretty slow is because we rely on sass.js which is very slow. That's the limitation.