search

dougmencken / HeadOverHeels

The free and open source remake of the game “Head over Heels”
GNU General Public License v3.0
33 stars 10 forks source link

GameManager looks too oversized, how about splitting it #55

Closed dougmencken closed 1 year ago

dougmencken commented 1 year ago

... and maybe it even smokes 😉

dougmencken commented 1 year ago

these look suspicious

https://github.com/dougmencken/HeadOverHeels/blob/8e2a963b2e7f900f17a3a7058950f12a6e05c247/src/PlayerItem.hpp#L59

https://github.com/dougmencken/HeadOverHeels/blob/8e2a963b2e7f900f17a3a7058950f12a6e05c247/src/PlayerItem.cpp#L434

GameManager as an argument, to copy the character-related data, and it's inside PlayerItem, hmmm ..... 🤔

dougmencken commented 1 year ago

it is also possible that this manager sometimes plays solitaire instead of managing

doesn't this

https://github.com/dougmencken/HeadOverHeels/blob/8e2a963b2e7f900f17a3a7058950f12a6e05c247/src/PlayerItem.hpp#L199

https://github.com/dougmencken/HeadOverHeels/blob/8e2a963b2e7f900f17a3a7058950f12a6e05c247/src/PlayerItem.hpp#L146

duplicate that

https://github.com/dougmencken/HeadOverHeels/blob/8e2a963b2e7f900f17a3a7058950f12a6e05c247/src/GameManager.hpp#L423

https://github.com/dougmencken/HeadOverHeels/blob/8e2a963b2e7f900f17a3a7058950f12a6e05c247/src/GameManager.hpp#L376

and so on ?

dougmencken commented 1 year ago

well, now it looks okay

https://github.com/dougmencken/HeadOverHeels/blob/2f70075db4691764a5dc1179c17117434dc4ee2a/src/GameManager.hpp#L127