search

dougmoscrop / serverless-http

Use your existing middleware framework (e.g. Express, Koa) in AWS Lambda 🎉
Other
1.74k stars 167 forks source link

implementation for multiple working set-cookie headers #16

Closed panva closed 7 years ago

panva commented 7 years ago
dougmoscrop commented 7 years ago

Looks great, thanks!

I notice you check if the header.toLowerCase() is 'set-cookie' -- in your experience are the headers ever not lower case? If they aren't then there seems to be a chance of headers being overwritten. This isn't relevant to your PR but I was curious about your experience.

panva commented 7 years ago

proprietary web server frameworks (non koa, non express, non hapi?) may choose to bypass res.setHeader and go for res._headers directly, doubt they would, but who knows.

resources: