search

dougmoscrop / serverless-http

Use your existing middleware framework (e.g. Express, Koa) in AWS Lambda 🎉
Other
1.71k stars 164 forks source link

#245 Add basePath to type definition for Options #246

Closed john-tipper closed 1 year ago

john-tipper commented 1 year ago

Fix #245 by adding in an optional basePath field to the Options type definition.

john-tipper commented 1 year ago

Thanks for merging this - it's a dependency of https://github.com/sladg/nextjs-lambda where I'm wanting to submit a PR to allow for Serverless Framework to be used instead of CDK, which requires me to put a change here: https://github.com/sladg/nextjs-lambda/blob/master/lib/standalone/server-handler.ts#L38-L40

To do this, I need the Typescript checks to pass, hence this PR. Please would you consider making a release to include this change?

dougmoscrop commented 1 year ago

Published at 3.0.3 @john-tipper - sorry, I get distracted easily!

john-tipper commented 1 year ago

Thanks very much!