search

dougmoscrop / serverless-http

Use your existing middleware framework (e.g. Express, Koa) in AWS Lambda 🎉
Other
1.71k stars 164 forks source link

When using ALB and Lambda with multi value headers, regular headers are not being added to the multiValueHeaders object #269

Open grillorafael opened 1 year ago

grillorafael commented 1 year ago

Hi,

{
  'headers': {
    'someHeader': 'someValue'
  },
  'multiValueHeaders': {
    'someOtherHeader': ['someOtherValue']
  }
}

The expected outcome is that 'multiValueHeaders' contains all headers

grillorafael commented 1 year ago

For context: when I swap to this library it works fine but serverless-http supports basePath with ALB which is what I need right now.

https://github.com/vendia/serverless-express

arcticShadow commented 1 year ago

Just hit this too. Would a PR be merged if one is provided?

dougmoscrop commented 1 year ago

Absolutely

arcticShadow commented 1 year ago

Probably should have linked it here when i posted it :-D https://github.com/dougmoscrop/serverless-http/pull/272

arcticShadow commented 1 year ago

FYI @grillorafael this is patched in master now.

grillorafael commented 1 year ago

I'll wait for the release. Thank you @arcticShadow !