search

dougmoscrop / serverless-http

Use your existing middleware framework (e.g. Express, Koa) in AWS Lambda 🎉
Other
1.71k stars 164 forks source link

Redid the integration tests using serverless-offline #288

Closed palfrey closed 9 months ago

palfrey commented 10 months ago

As part of looking at #280, I couldn't figure out how to get the integration tests running without actually deploying things to AWS. This PR redoes them with serverless-offline.

dougmoscrop commented 10 months ago

Interesting, I'm a fan of using the actual AWS service in case there's drift between serverless-offline, but I also see the value in being able to use it - do you think we could support both? npm run integration:offline, npm run integration:aws etc?

palfrey commented 10 months ago

Interesting, I'm a fan of using the actual AWS service in case there's drift between serverless-offline, but I also see the value in being able to use it - do you think we could support both? npm run integration:offline, npm run integration:aws etc?

Added. I've also plugged the offline integration into the new Github actions work.

dougmoscrop commented 9 months ago

@palfrey do you mind rebasing?

palfrey commented 9 months ago

This all got merged as part of https://github.com/dougmoscrop/serverless-http/pull/286