chai-as-promised dependency

dougmoscrop / serverless-http

Use your existing middleware framework (e.g. Express, Koa) in AWS Lambda 🎉

Other

1.74k stars 167 forks source link

chai-as-promised dependency #90

Closed jbarrus closed 5 years ago

jbarrus commented 5 years ago

NPM is showing chai-as-promised as a dependency in 2.0.1. I'm not sure how that happened, as the code here indicates that it's a devDependency. In any case, since most people wouldn't want chai running in production code, I think this should be removed.

from yarn info serverless-http

dependencies:
   { 'chai-as-promised':
      '^7.1.1',
     '@types/aws-lambda':
      '^8.10.19' },

in package.json in node_modules after installing

  "dependencies": {
    "chai-as-promised": "^7.1.1"
  }

dougmoscrop commented 5 years ago

Looks like something got messed up with package-lock.

$ npm i
$ git diff
diff --git a/package-lock.json b/package-lock.json
index 80a8b1b..f5c1562 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -823,6 +823,7 @@
       "version": "7.1.1",
       "resolved": "https://registry.npmjs.org/chai-as-promised/-/chai-as-promised-7.1.1.tgz",
       "integrity": "sha512-azL6xMoi+uxu6z4rhWQ1jbdUhOMhis2PvscD/xjLqNMkv3BPPp2JyyuTHOrf9BOosGpNQ11v6BKv/g57RXbiaA==",
+      "dev": true,
       "requires": {
         "check-error": "^1.0.2"
       }

dougmoscrop commented 5 years ago

How does 2.0.2 look from your side?

jbarrus commented 5 years ago

👍