search

dougmoscrop / serverless-plugin-include-dependencies

MIT License
184 stars 40 forks source link

Stop the aws-sdk exclusion #42

Closed sav-valerio closed 4 years ago

sav-valerio commented 4 years ago

AWS-SDK should be treated as a normal dependency, even if it's already available on the AWS Lambda environment.

Something might just break when AWS decides to upgrade the SDK version, without any warning.

From the official AWS docs: We recommend including your own copy of the AWS SDK for production applications so you can control your dependencies. https://docs.aws.amazon.com/lambda/latest/dg/accessing-resources.html

Fixes https://github.com/dougmoscrop/serverless-plugin-include-dependencies/issues/36

dougmoscrop commented 4 years ago

Yep only downside is it makes your package larger which can push people over the console edit. I think I will make this semver major just as a warning to users

sav-valerio commented 4 years ago

Yeah, I think too that a major version is the way to go.