Open mpvosseller opened 4 years ago
Ah, drat. This could probably be fixed by moving the 'core detection' in to this plugin.. so let precinct include core, then check the path or something.
Is there any update on this? What is the workaround in the meantime if we have config
modules in our app and if we still want to use this plugin?
node-config (aka
config
) does not get added as a dependency.This was also mentioned in a comment by @openam
I dug into this and the problem appears to be that we ignore "core" node modules and there is now an internal core module with the name "config" (see
process.binding('natives')['config']
)Not sure where a fix should live. My first thought is that ideally Precinct's
includeCore: false
parameter would not filter out dependencies that have the same name as a private/internal node module.