dougmoscrop / serverless-plugin-include-dependencies

MIT License
184 stars 40 forks source link

fix(get-dependency-list): add glob to dependency list and match existing behaviour on Windows. #83

Closed neverendingqs closed 1 year ago

neverendingqs commented 1 year ago

Resolves https://github.com/dougmoscrop/serverless-plugin-include-dependencies/issues/74#issuecomment-1213377321, https://github.com/dougmoscrop/serverless-plugin-include-dependencies/issues/75.

It's not explicitly spelled out in the Serverless documentation, but it looks like package.patterns should always be using /s anyway, so I don't think https://github.com/dougmoscrop/serverless-plugin-include-dependencies/blob/0c0fc72dd235c2ea5a25d45cf43c8b1c7ad8af37/include-dependencies.js#L59-L65 needs to be updated with the same change.

Open to feedback!


Quality notes: