search

dougmoscrop / serverless-plugin-include-dependencies

MIT License
184 stars 41 forks source link

fix: loosen up exclusions a bit #97

Closed tommarien closed 1 month ago

tommarien commented 6 months ago

As we are using a monorepo setup and some of our packages are containing binaries which we needed to exclude, we found out that the current exclusions package filtering is a bit too strict

Our current layout

--Root
  -- node_modules
     -- package_to_exclude
  -- apps
     -- app-one

In our case our node_modules end up in ../../node_modules/package_to_exclude which does not get excluded using minimatch because the filter for exclusions enforced either starting with !node_modules, equal to!node_modules or equal to !node_modules/**. So we can not exclude packages in our use-case

I've tried to loosen the restrictions a bit, so it can be used in both and probably more uses cases

Let me know if there is anything not ok with pull

Thx