search

dougnoel / sentinel

A Selenium/Appium framework that enables users to focus on automating web and windows tests, so that automated tests can be written in a non-technical way in the same amount of time as manual tests can be executed.
Apache License 2.0
11 stars 13 forks source link

verifyColumnCellsAreUnique is doing a contains when doing the comparison #547

Closed plmlkrz closed 1 year ago

plmlkrz commented 1 year ago

verifyColumnCellsAreUnique in Table.java is doing a contains when doing the comparison but since it is Unique, it should be doing an equals. Ran across an issue where in the table the value was "sphinganine-1-phosphate" and "sphinganine". The step failed because it thought that these were the same but they are unique. It should be set to equal.

for (String cell2 : column) { if (cell2.contains(cell)) { count++; } Should read for (String cell2 : column) { if (cell2.equals(cell)) { count++; }

tyBouch commented 1 year ago

I believe the PR should be handled, but it was not attached. Reopen if this is not the case.