dougnoel / sentinel

A Selenium/Appium framework that enables users to focus on automating web and windows tests, so that automated tests can be written in a non-technical way in the same amount of time as manual tests can be executed.
Apache License 2.0
11 stars 13 forks source link

DoesNotExist in custom steps is not functional. #553

Closed tyBouch closed 1 year ago

tyBouch commented 1 year ago

Unfortunately doesNotExist in custom steps was missed when modifying the functionality for Windows Elements. Rather than modifying the steps in Sentinel this update makes doesNotExist(boolean) a protected function, and overloads it based on the type of element to pass true or false to change how the iframe logic works. This will allow for the use of doesNotExist() without changes.

Issue was found with Salvo, which uses a number of custom steps with doesNotExist called midway through.