search

dougppaz / youtube-music-dl

Chrome Extension to download music file with tags and cover from Youtube Music.
MIT License
44 stars 4 forks source link

fix jDataView dep and mp4 downloading with incorrect filename #11

Closed OmgImAlexis closed 3 years ago

OmgImAlexis commented 3 years ago
  1. For some reason jDataView seems to have a broken npm package now so I switched that to use GitHub directly.
  2. mp4s were hitting this bug so I added a work around https://bugs.chromium.org/p/chromium/issues/detail?id=892133#c_ts1620794357
OmgImAlexis commented 3 years ago

@dougppaz any chance you could have a look at this?

dougppaz commented 3 years ago

seens look fine to me.. i upgrade to 1.1.2 just now.

OmgImAlexis commented 3 years ago

If you have a look at the link I provided this is an issue with some users. Can you please reopen this?

manuth commented 2 years ago

@OmgImAlexis I just gave it a go and it's working for me using Brave Version 1.33.106 Chromium: 96.0.4664.110 Are you still facing this issue?

OmgImAlexis commented 2 years ago

There's no way you can easily test this as it doesn't happen under any specific circumstances.

Some users will randomly find they hit this. When they do my changes fix the issue.

OmgImAlexis commented 2 years ago

@dougppaz please go and actually read the bug report. Also as a developer you should know "it works for me" isn't really a valid test. Your specific setup on your browser will be different to me and everyone else.

manuth commented 2 years ago

Oh fair - I hadn't noticed there's such a huge conversation going on in this bug report. I agree that it'd be best to have this PR merged, then.

Is the workaround mentioned in the SingleFile repo under Known Issues working for you while we're waiting for this to be merged?

Edit: never mind - just noticed that the only solution applicable to this extension mentioned on said page is reinstalling chrome 😵‍💫