search

dougshidong / PHiLiP

Parallel High-Order Library for PDEs through hp-adaptive Discontinuous Galerkin methods
Other
45 stars 37 forks source link

Restructuring PeriodicCubeFlow #139

Closed jbrillon closed 2 years ago

jbrillon commented 2 years ago

PR to restructure PeriodicCubeFlow by deriving PeriodicTurbulence from this class; done in support of PR #138.

dougshidong commented 2 years ago

Not sure I fully understand the goal of this commit and how it supports #138, but I see nothing "wrong" with this PR.

jbrillon commented 2 years ago

@dougshidong https://github.com/dougshidong/PHiLiP/pull/138#discussion_r866233739

dougshidong commented 2 years ago

Aaah I see. It was some copy pasted code. Yes this PR makes sense to me now.