search

dougshidong / PHiLiP

Parallel High-Order Library for PDEs through hp-adaptive Discontinuous Galerkin methods
Other
45 stars 37 forks source link

Create missing FlowSolverCase derived classes #153

Open jbrillon opened 2 years ago

jbrillon commented 2 years ago

In PR #111, flow case types burgers_inviscid, convection_diffusion, advection were added to enum FlowCaseType in parameters_flow_solver.cpp for the sole purpose of setting an initial condition, meaning they are not actually used in FlowSolverFactory since FlowSolverCase derived classes were not created for each of these "flow case types". We would want to create these and migrate their integration tests code appropriately to the flow solver framework.

acse-bn20 commented 1 year ago

Hi @dougshidong, can you assign this to me, please ?

jbrillon commented 1 year ago

An example of the procedure for migrating tests to the flow solver framework is PR #158