search

dougshidong / PHiLiP

Parallel High-Order Library for PDEs through hp-adaptive Discontinuous Galerkin methods
Other
45 stars 36 forks source link

Generate job parameter scripts from bash #157

Closed jbrillon closed 2 years ago

jbrillon commented 2 years ago

PR to add the option of generating cluster job submission file: job_parameters_file.sh using bash instead of manually editing it. Useful for quickly setting up many different jobs on the cluster.

dougshidong commented 2 years ago

Looks fine to me. One thing I'd change is the default number of cores being used or some kind of comment about a rule of thumb of number of cores per DoFs. Not sure what's a good rule of thumb with the current code status.

jbrillon commented 2 years ago

@dougshidong I agree but we'd have to wait for PR #111 to go through and do a scaling study since the new version of the Operators class will likely change things quite a bit.