dougshidong / PHiLiP

Parallel High-Order Library for PDEs through hp-adaptive Discontinuous Galerkin methods
Other
45 stars 37 forks source link

Move functionality of mesh adaptation to the flow solver. #159

Closed PranshulThakur closed 2 years ago

PranshulThakur commented 2 years ago

Currently, mesh adaptation is performed within ODESolverBase::steady_state(). To make the functions of ODESolver and MeshAdaptation separate, it would be better to move mesh adaptation to flow solver in future and call MeshAdaptation::adapt_mesh() after ODESolverBase::steady_state(). Some tests (such as the S-shock) do not use flow solver yet and these need to be modified to use the flow solver framework.

jbrillon commented 2 years ago

See comment in PR #155 : https://github.com/dougshidong/PHiLiP/pull/155#discussion_r913108351

jbrillon commented 2 years ago

See comment: https://github.com/dougshidong/PHiLiP/pull/156#pullrequestreview-1037607644