The conditional statements: (1)if (!this->all_parameters->use_split_form && !this->all_parameters->use_curvilinear_split_form) and (2)if (this->all_parameters->use_split_form || this->all_parameters->use_curvilinear_split_form) are used throughout the DGStrong class. It would be nice if this was handled within DGFactory where it would return the appropriate DGStrong derived class, e.g. return one of: DGStrong_Standard, DGStrong_Standard_Curvilinear, DGStrong_Split, DGStrong_Split_Curvilinear based on the 4 possible outcomes of the above 2 conditional statements.
The conditional statements: (1)
if (!this->all_parameters->use_split_form && !this->all_parameters->use_curvilinear_split_form)
and (2)if (this->all_parameters->use_split_form || this->all_parameters->use_curvilinear_split_form)
are used throughout theDGStrong
class. It would be nice if this was handled withinDGFactory
where it would return the appropriateDGStrong
derived class, e.g. return one of:DGStrong_Standard
,DGStrong_Standard_Curvilinear
,DGStrong_Split
,DGStrong_Split_Curvilinear
based on the 4 possible outcomes of the above 2 conditional statements.