`gmsh_reader` is called twice due to current implementation of `dg` and `high_order_grid`

dougshidong / PHiLiP

Parallel High-Order Library for PDEs through hp-adaptive Discontinuous Galerkin methods

Other

45 stars 36 forks source link

`gmsh_reader` is called twice due to current implementation of `dg` and `high_order_grid` #228

Open jbrillon opened 1 year ago

jbrillon commented 1 year ago

Currently, we have to pass a dummy triangulation to DG when using gmsh reader based on the current implementation of dg and high_order_grid. Right now, we're reading the mesh twice, and in the NACA0012 cases, we create a dummy using dealii then actually read in the mesh. See the conversation tagged to this issue.

_Originally posted by @jbrillon in https://github.com/dougshidong/PHiLiP/pull/171#discussion_r1096807143_

jbrillon commented 1 year ago

Also see comment https://github.com/dougshidong/PHiLiP/pull/171#discussion_r1199768342