Closed ssaishruthi98 closed 6 months ago
Is there any way for you to extract the limiter logic in a separate class? The DG class is already quite bloated and we're adding another 700 lines of code here. Right now we're using the DG class as some sort of object to hold global variables. Ideally, we would want to pass only the required inputs and return the solution with the limiteres applied.
SonarCloud Quality Gate failed.
0 Bugs
0 Vulnerabilities
0 Security Hotspots
9 Code Smells
No Coverage information
6.0% Duplication
Catch issues before they fail your Quality Gate with our IDE extension
SonarLint
@ssaishruthi98 if there is nothing else to fix, post a text file with the ctest results and we can approve/merge it if everything is good
Failed conditions
9.3% Duplication on New Code (required ≤ 3%)
Ran ctest and had a few failing tests: LastTestsFailed-20240226.log
Changed the parameter to GLL nodes for the Sod case and changed MPIMAX to 4 and reran failed tests: LastTestsFailed-20240227.log
The remaining failures are all known issues with the exception of the 2D_SUM_FACTORIZATION_HADAMARD_TEST
. The 2D_SUM_FACTORIZATION_HADAMARD_TEST
test fails sometimes and passes sometimes but I tested this on master and it has similar behaviour.
@dougshidong can we resolve your requested changes so that it can get merged?
Resolved. Thanks for the PR and the feedback implementations.
This PR is to incorporate bound-preserving limiters. It includes:
Added test cases to verify implementation. Cases include 1D & 2D Linear Advection, 1D & 2D Burgers', Sod Shock Tube, and the Leblanc Shock Tube case. OOA tests are all commented out. Ran ctest and all cases succeeded (except known issues).