Open ErwanLa opened 1 year ago
This would be a great time to remove FR related parameters from all_parameters
. I see you're passing an additional parameters to a bunch of functions. With a new FluxReconstructionParameter object, you can just pass that one object with all the necessary parameters instead of augmenting functions as we increase the number of parameters.
https://github.com/dougshidong/PHiLiP/issues/124 https://github.com/dougshidong/PHiLiP/issues/63
SonarCloud Quality Gate failed.
0 Bugs
0 Vulnerabilities
0 Security Hotspots
15 Code Smells
No Coverage information
30.1% Duplication
Catch issues before they fail your Quality Gate with our IDE extension
SonarLint
SonarCloud Quality Gate failed.
![]()
0 Bugs
![]()
0 Vulnerabilities
![]()
0 Security Hotspots
![]()
15 Code Smells
No Coverage information
30.1% Duplication
Catch issues before they fail your Quality Gate with our IDE extension
SonarLint
It looks like 30% of the PR is code duplication. Can you please look into extracting out common logic?
Implementation of user defined ESFR c parameter. (coded by Julien) chose : set flux_reconstruction = user_specified_value and set FR_user_specified_correction_parameter_value = [your value (double)].
3 tests order of accuracy over a range of ESFR parameter (1D linear advection, 1D inviscid Burger, 2D isentropic vortex): 1D linear advection, 1D inviscid Burger are implemented in a new testing file : src/testing/stability_fr_parameter_range.cpp 2D isentropic vortex is a modification of src/testing/h_refinement_study_isentropic_vortex.cpp to enable the use of a range of ESFR parameter.
To ease the use of a range of ESFR c parameter, I add 3 new parameters (number_ESFR_parameter_values, ESFR_parameter_values_start, ESFR_parameter_values_end)