dougshidong / PHiLiP

Parallel High-Order Library for PDEs through hp-adaptive Discontinuous Galerkin methods
Other
46 stars 37 forks source link

User defined ESFR parameter. #238

Open ErwanLa opened 1 year ago

ErwanLa commented 1 year ago

Implementation of user defined ESFR c parameter. (coded by Julien) chose : set flux_reconstruction = user_specified_value and set FR_user_specified_correction_parameter_value = [your value (double)].

3 tests order of accuracy over a range of ESFR parameter (1D linear advection, 1D inviscid Burger, 2D isentropic vortex): 1D linear advection, 1D inviscid Burger are implemented in a new testing file : src/testing/stability_fr_parameter_range.cpp 2D isentropic vortex is a modification of src/testing/h_refinement_study_isentropic_vortex.cpp to enable the use of a range of ESFR parameter.

To ease the use of a range of ESFR c parameter, I add 3 new parameters (number_ESFR_parameter_values, ESFR_parameter_values_start, ESFR_parameter_values_end)

dougshidong commented 1 year ago

This would be a great time to remove FR related parameters from all_parameters. I see you're passing an additional parameters to a bunch of functions. With a new FluxReconstructionParameter object, you can just pass that one object with all the necessary parameters instead of augmenting functions as we increase the number of parameters.

https://github.com/dougshidong/PHiLiP/issues/124 https://github.com/dougshidong/PHiLiP/issues/63

sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 15 Code Smells

No Coverage information No Coverage information
30.1% 30.1% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

dougshidong commented 1 year ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs Vulnerability A 0 Vulnerabilities Security Hotspot A 0 Security Hotspots Code Smell A 15 Code Smells

No Coverage information No Coverage information 30.1% 30.1% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

It looks like 30% of the PR is code duplication. Can you please look into extracting out common logic?

cpethrick commented 1 month ago

As discussed in a meeting today, I will work on this branch in the coming weeks to get it ready for another round of review and then merge it.