dougshidong / PHiLiP

Parallel High-Order Library for PDEs through hp-adaptive Discontinuous Galerkin methods
Other
45 stars 37 forks source link

Gradient at boundary not enforced for viscous flows #240

Open jbrillon opened 1 year ago

jbrillon commented 1 year ago

Currently, the gradient at the physical boundary (soln_grad_ext) set by boundary_face_values is not being enforced; as it is being set to the interior value (soln_grad_int) in all cases inside evaluate_auxiliary_flux.

To fix it, we must pass on_boundary flag to PhysicsBase's dissipative_flux and modify the dissipative flux accordingly; the fix take effect in assemble_boundary_term

jbrillon commented 1 year ago

will be fixed by https://github.com/jbrillon/PHiLiP/pull/11 once PR #199 goes through