search

dougshidong / PHiLiP

Parallel High-Order Library for PDEs through hp-adaptive Discontinuous Galerkin methods
Other
45 stars 37 forks source link

Clean-up DG #241

Closed dougshidong closed 1 year ago

dougshidong commented 1 year ago

The goal of this PR is to clean up some of the DG code.

  1. Separate the DGBase and DGBaseState into different files
  2. Introduce the LocalSolution class. It is now used in WeakDG, it still needs to be adopted elsewhere.
  3. Delete unused code, including many of the assemble_*_explicit() functions. Note that assemble_volume_explicit still exists. It's because it is somehow responsible for evaluating max_dt.

The next step in the clean up is to introduce a GlobalSolution class that can retrieve a LocalSolution. This should be the defacto object to be held by most of the current data structures that hold a DG for the sake of accessing the solution. StrongDG should also have changes to start using LocalSolution.

sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 106 Code Smells

No Coverage information No Coverage information
12.5% 12.5% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint