Closed AlexanderCicchino closed 1 year ago
That would be a great test to have along with this PR while you're fixing it. The odds that someone puts a test for this in 4 years are pretty much nil and currently open issues don't exactly get resolved.
Approving since a fix is better than no fix, but highly suggesting a test.
Also, at this point, split form should pretty much be its own form of DG.
I agree. I didn't put a test because I was under the impression that another student is looking into applying a test using BC with NSFR. Yes I also agree that the split form should pretty much be its own form from DG by this point.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
I read through the strong DG boundary integral, saw that the surafce numerical flux used the solution interpolated to the surface, and updated the convective surface numerical flux and boundary term to use the projected entropy variables. There is no test verifying this currently. A good test would be checking entropy conservation with the boundary condition entropy production to machine precision.