search

dougshidong / PHiLiP

Parallel High-Order Library for PDEs through hp-adaptive Discontinuous Galerkin methods
Other
45 stars 37 forks source link

Strong DG NSFR boundary integral now uses projected entropy variables. #245

Closed AlexanderCicchino closed 1 year ago

AlexanderCicchino commented 1 year ago

I read through the strong DG boundary integral, saw that the surafce numerical flux used the solution interpolated to the surface, and updated the convective surface numerical flux and boundary term to use the projected entropy variables. There is no test verifying this currently. A good test would be checking entropy conservation with the boundary condition entropy production to machine precision.

AlexanderCicchino commented 1 year ago

That would be a great test to have along with this PR while you're fixing it. The odds that someone puts a test for this in 4 years are pretty much nil and currently open issues don't exactly get resolved.

Approving since a fix is better than no fix, but highly suggesting a test.

Also, at this point, split form should pretty much be its own form of DG.

I agree. I didn't put a test because I was under the impression that another student is looking into applying a test using BC with NSFR. Yes I also agree that the split form should pretty much be its own form from DG by this point.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication