search

dougshidong / PHiLiP

Parallel High-Order Library for PDEs through hp-adaptive Discontinuous Galerkin methods
Other
45 stars 36 forks source link

Fixed exterior reference normal zone issue in strong. #250

Closed AlexanderCicchino closed 7 months ago

AlexanderCicchino commented 9 months ago

This PR fixes/closes the zone issue in strong DG as per issue #249 . The problem was that previously, on a face, it was assumed that the reference faces were neighbours, which is the case for grids made from hypercube and a warping or a single mesh in dealii. In the general case, this isn't, and now it has been fixed. Note, the reference cell itself could be rotated and no longer be a square going from 0->1, that case has not been tested in strong. strong_naca0012_solution

cpethrick commented 9 months ago

Thanks for fixing this, Alex! I'm really glad that this was able to be resolved so quickly.

I think it's good to add these new tests, but we should have a testfail condition. I can do that in the next few days: it will check that weak and strong have the expected lift (with some small tolerance) after the short unsteady time interval. I'll add it to this branch once it's done.

AlexanderCicchino commented 9 months ago

My pleasure, hope it helps!

dougshidong commented 9 months ago

Thanks for fixing this, Alex! I'm really glad that this was able to be resolved so quickly.

I think it's good to add these new tests, but we should have a testfail condition. I can do that in the next few days: it will check that weak and strong have the expected lift (with some small tolerance) after the short unsteady time interval. I'll add it to this branch once it's done.

+1 to the test success / failure condition.

sonarcloud[bot] commented 9 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
1.3% 1.3% Duplication

cpethrick commented 9 months ago

I just added a new test that checks lift and drag for the three NACA0012 unsteady tests (weak/strong/strong-split). They currently pass on this branch, but the two strong versions fail on master.

I am starting CTEST. It should finish some time tomorrow.

cpethrick commented 9 months ago

ctest has completed and all tests are passing as expected. See the attached log file. ctest07122023.txt

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

5 New issues
0 Security Hotspots
No data about Coverage
1.1% Duplication on New Code

See analysis details on SonarCloud