dougshidong / PHiLiP

Parallel High-Order Library for PDEs through hp-adaptive Discontinuous Galerkin methods
Other
45 stars 37 forks source link

ECSW Hyperreduction Code and Tests #254

Closed biondicc closed 4 months ago

biondicc commented 8 months ago

Pull request for the addition of the energy-conserving sampling and weighting hyperreduction technique into the projection-based ROMs previously tested.

Non-negative least squares solver (added to the linear_solver directory):

ode_solver directory changes:

parameters directory changes:

reduced_order directory changes:

Test changes:

cpethrick commented 5 months ago

Everything looks good on my end!

Great work on this PR, you've done a lot of good work with reorganizing the ROM portion of the code! I hope that your changes make it easier for future students to continue development of ROM/HROM :)

I will approve once you post the ctest results.

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

biondicc commented 4 months ago

Here are the files which contain the tests that fail when I run ctest in my branch.

The first (Failed.log) is before I updated the helper functions, which were causing some of the hyperreduction tests to fail. Failed.log

Once I updated the helper functions/some of the tolerances in my prm files in the latest commit, I re-ran ctest from test 274 onwards and the hyperreduction tests all passed, this was the new failed test log. LastTestsFailed.log

Thank you to the reviewers for all your helpful comments and support! Let me know if there are still open questions.