dougshidong / PHiLiP

Parallel High-Order Library for PDEs through hp-adaptive Discontinuous Galerkin methods
Other
45 stars 37 forks source link

Fix for output files being overwritten #255

Closed ssaishruthi98 closed 7 months ago

ssaishruthi98 commented 7 months ago

When outputting files using the parameter output_solution_every_dt_time_intervals there are instances where casting to int results in the same file_number being used twice. When the same file_number is used twice, the previous output file is overwritten with the newer output. Examples of these cases are shown below.

fileOutputBug_1 fileOutputBug_2

To fix this I changed the type for file_number to double so that the round function can be used. With this fix, output files are no longer being overwritten.

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud