dougshidong / PHiLiP

Parallel High-Order Library for PDEs through hp-adaptive Discontinuous Galerkin methods
Other
45 stars 37 forks source link

Clean up periodic flow solver cases #256

Open cpethrick opened 7 months ago

cpethrick commented 7 months ago

Opened by request of @jbrillon. See: PR comment .

Next time I work on the flow solver, I will reconsider the periodic_turbulence and periodic_entropy_tests. There is a lot of repeated logic in the two classes. The reason why they are separate currently is to separate flow solver cases by the physics which they would be expected to solve.

I would possibly move the numerical entropy calculations into a different class entirely.