dougshidong / PHiLiP

Parallel High-Order Library for PDEs through hp-adaptive Discontinuous Galerkin methods
Other
45 stars 37 forks source link

Low Storage Runge-Kutta #259

Closed jocelynpoon closed 2 months ago

jocelynpoon commented 4 months ago

PR for the Low Storage RK Method

Code for [3S] and [3S+] methods. Tableaus for RK4(3)5[3S], RK3(2)5F[3S+], RK4(3)9F[3S+], and RK4(4)10F[3S+] schemes.

low_storage_runge_kutta_ode_solver.cpp

low_storage_rk_tableau_base.cpp

low_storage_runge_kutta_methods.cpp

parameters_ode_solver.cpp

ctest log: (some tests that failed in the log don't fail anymore because I reverted the tests back to what's on master) log.txt

jocelynpoon commented 2 months ago

Hi Carolyn and Shruthi, thanks for going through my code and leaving comments. I went through all your comments and made changes. Let me know if you see anything else that should be changed, thanks!

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
23 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.6% Duplication on New Code

See analysis details on SonarCloud