search

dougshidong / PHiLiP

Parallel High-Order Library for PDEs through hp-adaptive Discontinuous Galerkin methods
Other
45 stars 37 forks source link

Clean pull-request for Beluga scripts from Alex C. #77

Closed jbrillon closed 3 years ago

jbrillon commented 3 years ago

Supersedes PR#75 created by Alex to clean up commits that got added from another draft PR.

dougshidong commented 3 years ago

Thanks for the clean PR. @AlexanderCicchino any reason why it's a new file rather than modifying job_compile_PHiLiP.sh? Becomes confusing if we have multiple files that supposedly do the same, but one becomes deprecated.

Helps to keep track which modules have changed with the different versions in case we need to rollback to some previous PHiLiP version.

AlexanderCicchino commented 3 years ago

Yes, for the simple reason that I didn't know about the file job_compile_PHiLiP.sh. In hindsight, it is nice for new students to see how the changes were made as Beluga updated their modules.

jbrillon commented 3 years ago

@dougshidong @AlexanderCicchino Should I overwrite job_compile_PHiLiP.sh so this can be merged?

dougshidong commented 3 years ago

Yes please.

jbrillon commented 3 years ago

Done

dougshidong commented 3 years ago

Yes, for the simple reason that I didn't know about the file job_compile_PHiLiP.sh. In hindsight, it is nice for new students to see how the changes were made as Beluga updated their modules.

Makes sense. I sent you the script before it was commited.

Thanks for the change Julien.