ODESolver::advance_solution_time will not work with Implicit_ODESolver

dougshidong / PHiLiP

Parallel High-Order Library for PDEs through hp-adaptive Discontinuous Galerkin methods

Other

45 stars 36 forks source link

ODESolver::advance_solution_time will not work with Implicit_ODESolver #80

Closed dougshidong closed 2 years ago

dougshidong commented 2 years ago

Since there is a linesearch within Implicit_ODESolver, step_in_time does not necessarily steps in time by the correct amount. The solution would be to change the current Implicit_ODESolver into a Implicit_SteadyStateSolver, and have an actual BackwardEuler class that actually steps in time implicitly.

dougshidong commented 2 years ago

Commit b2e53a0ad8335a776ce154d7b009f2d885cadf6d fixes this issue.