dougshidong / PHiLiP

Parallel High-Order Library for PDEs through hp-adaptive Discontinuous Galerkin methods
Other
45 stars 36 forks source link

Flow Solver Test Case #87

Closed jbrillon closed 2 years ago

jbrillon commented 2 years ago

Pull request to incorporate the addition of the abstract FlowSolver class derived from TestBase. The purpose of this class is to unify the codes/scripts within src/testing/ that simulate an unsteady flow case, where the different flow cases will be ran using the flow_solver.cpp and an appropriate .prm file.

This is accomplished within FlowSolver by:

As a first case, the Taylor Green Vortex (turbulent) flow case has been implemented, both inviscid and viscous; included in the class PeriodicCubeFlow derived from FlowSolver and InitialConditionFunction_TaylorGreenVortex class derived from InitialConditionFunction

Additional contributions:

Current limitations:

dougshidong commented 2 years ago

Consider opening up that PR soon if it's working. It's already starting to be on the bigger side.

jbrillon commented 2 years ago

@dougshidong Yep, that's the plan

dougshidong commented 2 years ago

Regarding format. First issue I'm tackling when I'm done with some of the PhD is: https://github.com/dougshidong/PHiLiP/issues/98

This will automatically format code such that spacing is not an issue anymore.

dougshidong commented 2 years ago

Looks like FlowSolver is currently quite specific to TGV. Especially since you are checking for some specific condition in between each step.